Run scripts/PublicAPI/mark-shipped.cmd #38594
Conversation
| @@ -1,0 +1,56 @@ | |||
| Microsoft.CodeAnalysis.CSharp.Formatting.BinaryOperatorSpacingOptions | |||
There was a problem hiding this comment.
@sharwell: what's the plan for a "public API" surface area in this assembly? Shouldn't this all be internal?
There was a problem hiding this comment.
(this is not a question about this particular thing but rather asking what it even means to run the analyzer on this assembly)
There was a problem hiding this comment.
The code style packages do not have a public API. Or more specifically, we always assume that there is no downstream code referencing these assemblies and are free to break them at will. We do not distribute the compiled binaries in any package which makes them available for reference/use by other code.
There was a problem hiding this comment.
@sharwell: should we just turn off the analyzers for them then?
There was a problem hiding this comment.
If they don't have a public API that we intend to support then we should turn off the analyzer and delete the shipped / unshipped files. That is the expected state for non-public API assemblies.
There was a problem hiding this comment.
That would be fine with me. However, if we plan to try and ship these later (so consolidate analyzer implementations in NuGet and VSIX) then we would need them added back.
| @@ -1,0 +1,56 @@ | |||
| Microsoft.CodeAnalysis.CSharp.Formatting.BinaryOperatorSpacingOptions | |||
There was a problem hiding this comment.
(this is not a question about this particular thing but rather asking what it even means to run the analyzer on this assembly)
5 participants
Fixes #37443. @JoeRobich fyi, this is almost certainly going to cause merge conflicts when it makes its way to master.