Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify semantic model on suppression operator #38756

Merged
merged 2 commits into from
Sep 21, 2019
Merged

Verify semantic model on suppression operator #38756

merged 2 commits into from
Sep 21, 2019

Conversation

jcouv
Copy link
Member

@jcouv jcouv commented Sep 19, 2019 •
edited
Loading

Uncommenting some verification in tests for suppressions.
Closes #32661
Closes #38343

Also closes #38543 (problem with binding of async lambdas allowing a void to be returned) by adding a test

@jcouv jcouv added this to the 16.4 milestone Sep 19, 2019
@jcouv jcouv self-assigned this Sep 19, 2019
@jcouv jcouv marked this pull request as ready for review September 19, 2019 06:57
@jcouv jcouv requested a review from a team as a code owner September 19, 2019 06:57
@jcouv jcouv added the Test Test failures in roslyn-CI label Sep 19, 2019
gafter
gafter approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jcouv jcouv merged commit 92c834f into dotnet:master Sep 21, 2019
@jcouv jcouv deleted the suppression-semantic branch September 21, 2019 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gafter gafter gafter approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers New Language Feature - Nullable Reference Types Nullable Reference Types Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.4
2 participants
@jcouv @gafter