Spelling fixes #38977
Merged
Spelling fixes #38977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genlu
approved these changes
Oct 1, 2019
Member
genlu
left a comment
genlu
left a comment
There was a problem hiding this comment.
LGTM. Some of the change involves tests, but they don't seem to affect the logic.
jasonmalinowski
requested changes
Oct 1, 2019
Member
jasonmalinowski
left a comment
jasonmalinowski
left a comment
There was a problem hiding this comment.
One test's spelling error is intentional -- we'll want to revert the change to that one test.
src/Compilers/VisualBasic/Test/Semantic/Compilation/GetSemanticInfoBrokenCodeTests.vb
Outdated
Show resolved
Hide resolved
genlu
requested changes
Oct 1, 2019
Member
genlu
left a comment
genlu
left a comment
There was a problem hiding this comment.
rescind the approval until the test is fixed
cston
approved these changes
Oct 2, 2019
genlu
approved these changes
Oct 2, 2019
Contributor
|
@jasonmalinowski, please review. |
jasonmalinowski
approved these changes
Oct 3, 2019
Contributor
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.