Skip to content

Conversation

@nnpcYvIVl
Copy link
Contributor

No description provided.

@nnpcYvIVl nnpcYvIVl requested review from a team as code owners October 4, 2019 13:15
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 4, 2019
Copy link
Member

@dibarbet dibarbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from the IDE side, but it looks like it will need a review from @dotnet/roslyn-compiler as there is a compiler file in there.

@RikkiGibson
Copy link
Member

There are conflicts, please merge latest master into your PR branch

@nnpcYvIVl
Copy link
Contributor Author

@RikkiGibson Thanks for the heads-up, merged with master.

@jinujoseph jinujoseph added this to the 16.4.P3 milestone Oct 10, 2019
@jinujoseph jinujoseph merged commit 9f0d3fc into dotnet:master Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants