Skip to content

Fix: Underselection test bug #39091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 9, 2019
Merged

Fix: Underselection test bug #39091

merged 6 commits into from
Oct 9, 2019

Conversation

@petrroll
Copy link
Contributor

@petrroll petrroll commented Oct 6, 2019

@petrroll petrroll requested a review from a team as a code owner October 6, 2019 22:28
@petrroll petrroll mentioned this pull request Oct 6, 2019
Closed
@petrroll petrroll changed the base branch from master to release/dev16.4-preview2 October 6, 2019 22:30
@petrroll petrroll changed the title Underselection test bug Fix: Underselection test bug Oct 6, 2019
@petrroll
Copy link
Contributor Author

petrroll commented Oct 6, 2019

Not sure I'm targeting the correct branch, if possible this should get fixed before next 16.4 preview. It also needs to flow to master but I assume that's still automatic (and this branch isn't abandoned).

miloush
miloush reviewed Oct 6, 2019
View reviewed changes
miloush
miloush reviewed Oct 6, 2019
View reviewed changes
@mavasani
Copy link
Contributor

mavasani commented Oct 6, 2019

This branch is no longer maintained. You can retarget to master. Thanks!

@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 6, 2019
@jinujoseph
Copy link
Contributor

jinujoseph commented Oct 6, 2019

@petrroll thanks for the fix, would you pls retarget this to master pls

CyrusNajmabadi
CyrusNajmabadi reviewed Oct 7, 2019
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stuff

@petrroll petrroll changed the base branch from release/dev16.4-preview2 to master October 7, 2019 12:13
@petrroll
Copy link
Contributor Author

petrroll commented Oct 7, 2019

Feedback addressed + cleaned up Tuple usage.

@petrroll petrroll requested review from CyrusNajmabadi and removed request for a team October 7, 2019 12:28
CyrusNajmabadi
CyrusNajmabadi reviewed Oct 7, 2019
View reviewed changes
CyrusNajmabadi
CyrusNajmabadi approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good :)

@petrroll
Copy link
Contributor Author

petrroll commented Oct 9, 2019

Please review @mavasani

@mavasani mavasani merged commit 36b4bc5 into dotnet:master Oct 9, 2019
@mavasani
Copy link
Contributor

mavasani commented Oct 9, 2019

Thanks @petrroll!

@mavasani mavasani added this to the 16.4.P3 milestone Oct 9, 2019
@petrroll petrroll mentioned this pull request Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+2 more reviewers

@miloush miloush miloush left review comments

@mavasani mavasani mavasani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mavasani mavasani

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Milestone

16.4.P3

Development

Successfully merging this pull request may close these issues.

5 participants

@petrroll @mavasani @jinujoseph @CyrusNajmabadi @miloush