Remove analyzer workarounds for using declarations #39324
Conversation
| @@ -125,13 +125,6 @@ protected override void InitializeWorker(AnalysisContext context) | |||
| ComputeDiagnostics(disposeDataAtExit, notDisposedDiagnostics, mayBeNotDisposedDiagnostics, | |||
| disposeAnalysisResult, pointsToAnalysisResult); | |||
|
|
|||
| if (disposeAnalysisResult.ControlFlowGraph.OriginalOperation.HasAnyOperationDescendant(o => o.Kind == OperationKind.None)) | |||
There was a problem hiding this comment.
Thanks @chsienki. On second thought, I am wondering if we should leave these checks in place to future proof the analyzers from false positives in case of future language features with unimplemented IOperation support.
There was a problem hiding this comment.
I did wonder that too. Perhaps we should Debug.Assert? Given that we shouldn't have none operations in reality, it will stop anything breaking, but save as a catch for future language features?
There was a problem hiding this comment.
Unfortunately, we do have bunch of nodes generated with OperationKind.None due to pending IOperation support (attributes, query clauses, unsafe code, VB xml literals, etc.)
There was a problem hiding this comment.
Ah ok. I guess we'll just leave this as-is then.
Remove workarounds introduced introduced in #36734 as #32100 is now implemented.