Fix SkipLocalsInit with stackalloc #39612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackalloc is affected by the locals init flag, but the locals init flag is only present if the fat IL header is used, which is not preferred if the method is small and has no locals. S.R.M added a parameter to allow callers to indicate that stackalloc is present and thus localsinit should be respected when deciding to use the fat or tiny IL header. This change tracks whether there is a stackalloc while doing codegen and plumbs the result into S.R.M.
AlekseyTs
reviewed
Nov 1, 2019
AlekseyTs
reviewed
Nov 1, 2019
I think this overload should also return Refers to: src/Compilers/CSharp/Portable/CodeGen/CodeGenerator.cs:208 in 4cfed1c. [](commit_id = 4cfed1c, deletion_comment = False) |
|
Done with review pass (iteration 1) #Closed |
AlekseyTs
reviewed
Nov 1, 2019
AlekseyTs
reviewed
Nov 1, 2019
AlekseyTs
approved these changes
Nov 1, 2019
RikkiGibson
approved these changes
Nov 4, 2019
| } | ||
| }"; | ||
| var verifier = CompileAndVerifyWithSkipLocalsInit(src); | ||
| Assert.Null(verifier.HasLocalsInit("C.M1")); // no locals |
There was a problem hiding this comment.
What is demonstrated by the realIL: false case? Is it that we can't tell using IL visualization whether the method has SkipLocalsInit, because the method has a tiny header?
There was a problem hiding this comment.
Yup, it shows no locals, which is not enough information.
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stackalloc is affected by the locals init flag, but the locals init
flag is only present if the fat IL header is used, which is not
preferred if the method is small and has no locals. S.R.M added
a parameter to allow callers to indicate that stackalloc is present
and thus localsinit should be respected when deciding to use the
fat or tiny IL header. This change tracks whether there is a stackalloc
while doing codegen and plumbs the result into S.R.M.