Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a space to experience e2e getting sources, making change, and subm... #4

Merged
merged 1 commit into from
Jan 15, 2015
Merged

added a space to experience e2e getting sources, making change, and subm... #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
README
======

This file is a placeholder. This directory will contain public documentation.
This file is a placeholder. This directory will contain public documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we preferred one space after periods now? We may need to publish a documentation style guide... :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, one space after period is clearly superior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is one space the standard we use in docs? If so then we should undo this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we had a standard. @dpoeschl might have been referring to the widely held opinion that double spaces are a holdover from the typewriter days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the file is authored in VI, you should use one space after a period. Otherwise two spaces are permissible. This clearly proves that VI is the superior editor. ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

Two spaces after a period is fine in markdown. It improves readability in the raw markdown but will still be rendered as a single space by browsers after being converted to HTML.

Miguel's Markdown Style Guide.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BUT I LOOK AT THE SOURCE IN VI AND TWO SPACES ARE WRONG.

Pro tip: If you're losing an argument, use all caps. This helps convincing people.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you've oversold the "pro" in "pro tip"

Oooo! Burn!

Also, you're all jerks. Is this what you're like when there's not enough code to review? Go fix some bugs! 😃 😃 😃

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍