Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make finding checksum async #40091

Merged
merged 4 commits into from
Dec 5, 2019
Merged

Make finding checksum async #40091

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5b6ad0
Make finding checksum async
tmat Dec 2, 2019
6bb9d11
Feedback
tmat Dec 3, 2019
57e0a3b
Clean up TryRunCodeAnalysisRemoteAsync
tmat Dec 4, 2019
5342cf4
Feedback
tmat Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/EditorFeatures/TestUtilities/Remote/InProcRemostHostClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
// Copyright (c) Microsoft. All Rights Reserved. Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

#nullable enable

using System;
using System.Collections.Generic;
using System.Diagnostics;
Expand Down Expand Up @@ -87,8 +89,8 @@ public Task<Stream> RequestServiceAsync(string serviceName)

public override string ClientId { get; }

public override async Task<Connection> TryCreateConnectionAsync(
string serviceName, object callbackTarget, CancellationToken cancellationToken)
public override async Task<Connection?> TryCreateConnectionAsync(
string serviceName, object? callbackTarget, CancellationToken cancellationToken)
{
// get stream from service hub to communicate service specific information
// this is what consumer actually use to communicate information
Expand Down
5 changes: 3 additions & 2 deletions ...le/Completion/Providers/ImportCompletionProvider/ExtensionMethodImportCompletionHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,12 @@ public static async Task<ImmutableArray<SerializableImportCompletionItem>> GetUn
CancellationToken cancellationToken)
{
var project = document.Project;
var (serializableItems, counter) = await client.TryRunCodeAnalysisRemoteAsync<(IList<SerializableImportCompletionItem>, StatisticCounter)>(
var (serializableItems, counter) = (await client.TryRunCodeAnalysisRemoteValueAsync<(IList<SerializableImportCompletionItem>, StatisticCounter)>(
project.Solution,
nameof(IRemoteExtensionMethodImportCompletionService.GetUnimportedExtensionMethodsAsync),
new object[] { document.Id, position, SymbolKey.CreateString(receiverTypeSymbol), namespaceInScope.ToArray(), forceIndexCreation },
cancellationToken).ConfigureAwait(false);
cancellationToken).ConfigureAwait(false)).GetValueOrDefault();


return (serializableItems.ToImmutableArray(), counter);
}
Expand Down
6 changes: 3 additions & 3 deletions src/Features/Core/Portable/DesignerAttributes/AbstractDesignerAttributeService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ public async Task<DesignerAttributeResult> ScanDesignerAttributesAsync(Document

private async Task<DesignerAttributeResult> ScanDesignerAttributesInRemoteHostAsync(RemoteHostClient client, Document document, CancellationToken cancellationToken)
{
return await client.TryRunCodeAnalysisRemoteAsync<DesignerAttributeResult>(
return (await client.TryRunCodeAnalysisRemoteValueAsync<DesignerAttributeResult>(
document.Project.Solution,
nameof(IRemoteDesignerAttributeService.ScanDesignerAttributesAsync),
document.Id,
cancellationToken).ConfigureAwait(false);
new[] { document.Id },
cancellationToken).ConfigureAwait(false)).GetValueOrDefault();
}

private async Task<DesignerAttributeResult> ScanDesignerAttributesInCurrentProcessAsync(Document document, CancellationToken cancellationToken)
Expand Down
30 changes: 0 additions & 30 deletions src/Test/Diagnostics/RemoteHost/RemoteHostPanel.xaml
View file
Open in desktop

This file was deleted.

132 changes: 0 additions & 132 deletions src/Test/Diagnostics/RemoteHost/RemoteHostPanel.xaml.cs
View file
Open in desktop

This file was deleted.

169 changes: 0 additions & 169 deletions src/Test/Diagnostics/RemoteHost/SolutionAssetManager.cs
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions src/Test/Diagnostics/Roslyn.Hosting.Diagnostics.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,5 @@
<SubType>Designer</SubType>
<Generator>MSBuild:Compile</Generator>
</Page>
<Page Include="RemoteHost\RemoteHostPanel.xaml">
<Generator>MSBuild:Compile</Generator>
</Page>
</ItemGroup>
</Project>
Loading