Skip to content

Merge feature branch features/editorconfig-generated-code into master #40456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 20, 2019
Merged

Merge feature branch features/editorconfig-generated-code into master #40456

merged 15 commits into from
Dec 20, 2019

Conversation

mavasani
Copy link
Contributor

Fixes #3705

mavasani and others added 13 commits September 25, 2019 14:42
@mavasani
Add analyzer driver editorconfig option for end users to configure ge…
5153177 
…nerated code

Implements #38674 (comment)
Fixes #3705
@mavasani
Merge pull request #38859 from mavasani/generated_code
71c80fc 
Add analyzer driver editorconfig option for end users to configure ge…
@agocke
Add API for marking a syntax tree as generated (#39051)
4dce8d6 
Provides API to fix #3705.
@mavasani
Pass in the "isGeneratedCode" flag from editorconfig options into syn…
dca3ebd 
…tax tree parse APIs in command line compiler and IDE syntax tree factory service.

Builds on top of #39051
Addresses #3705
@mavasani
Respect .editorconfig generated code entry in IGeneratedCodeRecogniti…
d770ec8 
…onService
@mavasani
Fix unit test
02dfbc3
@mavasani
Merge remote-tracking branch 'upstream/master' into merge-master
2cb06bf
@mavasani
Merge pull request #40363 from mavasani/merge-master
4e60383 
Merge master into features/editorconfig-generated-code
@mavasani
Merge remote-tracking branch 'upstream/features/editorconfig-generate…
b1ac733 
…d-code' into ConsumeGeneratedCodeApi
@mavasani
Address review feedback
d4dd2b5
@mavasani
Review feedback
70660f7
@mavasani
Update test
3651de2
@JoeRobich
Merge pull request #40330 from mavasani/ConsumeGeneratedCodeApi
efb6a23 
Pass in the "isGeneratedCode" flag from editorconfig options into syn…
@mavasani mavasani added this to the 16.5.P2 milestone Dec 17, 2019
@mavasani mavasani requested review from agocke and a team December 17, 2019 21:02
@mavasani mavasani requested review from a team as code owners December 17, 2019 21:02
@mavasani
Copy link
Contributor Author

@dotnet/roslyn-compiler - does PR merging a feature branch to master need 2 compiler signoffs?

333fred
333fred reviewed Dec 19, 2019
View reviewed changes
@333fred
Copy link
Member

333fred commented Dec 19, 2019 

    public static SyntaxTree ParseSyntaxTree(

This API, for reference from my comment in the public API file

Refers to: src/Compilers/CSharp/Portable/Syntax/SyntaxFactory.cs:1569 in efb6a23. [](commit_id = efb6a23, deletion_comment = False)

333fred
333fred requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing backcompat overload.

@mavasani mavasani mentioned this pull request Dec 19, 2019
Merged
@mavasani mavasani requested a review from 333fred December 19, 2019 21:14
@mavasani mavasani merged commit a4a9cb4 into master Dec 20, 2019
@Nitin5acc
Copy link

Hi,

Are they any examples on how to use it? We do not want code analyzer to run on certain files in a solution.

@mavasani mavasani deleted the features/editorconfig-generated-code branch January 5, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@agocke agocke Awaiting requested review from agocke

Assignees
No one assigned
Labels
Area-Analyzers Area-Compilers
Projects
None yet
Milestone
16.5.P2
Development

Successfully merging this pull request may close these issues.

Exclude files or folder from running through the analyzers through a configuration file.
5 participants
@mavasani @333fred @Nitin5acc @agocke @JoeRobich