Implement designator restrictions for C# 9.0 patterns #40543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gafter
added
Area-Compilers
New Language Feature - Pattern Matching
|
@agocke @RikkiGibson @dotnet/roslyn-compiler Could you please review this change in support for C# 9.0 pattern-matching? #Resolved |
RikkiGibson
approved these changes
Dec 27, 2019
|
@dotnet/roslyn-compiler Could I please get a review from a Sr engineer? #Resolved |
|
Looking. Could you open a test plan issue (requires coming up with a moniker for feature, perhaps "combinator patterns")? #Resolved |
jcouv
reviewed
Jan 3, 2020
| if (o is 1 or int y3) { } | ||
| if (o is (1 or 2) or int y4) { } | ||
| if (o is not int y5) { } | ||
| if (o is not (1 and int y6)) { } |
There was a problem hiding this comment.
Consider other nesting cases: Point { X: var x } or Animal and Point (var x, _) or Animal and is object or (1 or var x), etc #Resolved
…into patterns3-40533
This was referenced Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40533
Relates to dotnet/csharplang#2850
Relates to #40727 (test plan for C# 8 patterns)