Switch to UI thread before invoking Workspace.TryApplyChanges #41461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently changed this code to switch from using the Workspace Options setter (now deprecated) to Workspace.TryApplyChanges. This causes an intermittent exception [here](https://github.com/dotnet/roslyn/blob/aeb47891e92341b700c3a290a92553b8a91b445a/src/VisualStudio/Core/Def/Implementation/ProjectSystem/VisualStudioWorkspaceImpl.cs#L374-L377) when TryApplyChanges is invoked from a background thread. Fixes internal Watson bug [#1062942](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1062942)
mavasani
added
Area-IDE
Tenet-Reliability
sharwell
approved these changes
Feb 6, 2020
Contributor
Author
|
Tagging @jinujoseph - this needs M2 approval. |
Member
|
Looking at the integration logs it seems like this is still running against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed this code to switch from using the Workspace Options setter (now deprecated) to Workspace.TryApplyChanges. This causes an intermittent exception here when TryApplyChanges is invoked from a background thread.
Fixes internal Watson bug #1062942