Remove unused parameters. #41513
Merged
Remove unused parameters. #41513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tagging @mavasani |
Member
Author
|
@mavasani , this PR in particular doesn't even seem like it needs to be part of the "move helpers down" change. It's purely a cleanup change. Certainly good o have. But it's just extra stuff to review as part of the large change that doesn't seem necessary. |
jinujoseph
added
Area-IDE
Community
mavasani
approved these changes
Feb 10, 2020
| Return VBFeaturesResources.Remove_Me_qualification | ||
| End Function | ||
|
|
||
| Protected Overrides Function Rewrite(semanticModel As SemanticModel, root As SyntaxNode, memberAccessNodes As ISet(Of MemberAccessExpressionSyntax)) As SyntaxNode |
Member
There was a problem hiding this comment.
@CyrusNajmabadi Can we get rid of semanticModel being passed down at any higher level?
Member
Author
There was a problem hiding this comment.
Will look into doing that!
Member
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #41510 to make that PR easier to review.