Skip to content

Conversation

@dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from master into features/local-function-attributes.

git fetch --all
git checkout merges/master-to-features/local-function-attributes
git reset --hard upstream/features/local-function-attributes
git merge upstream/master
# Fix merge conflicts
git commit
git push upstream merges/master-to-features/local-function-attributes --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

@dotnet-bot dotnet-bot requested a review from a team as a code owner February 14, 2020 00:02
@dotnet-bot dotnet-bot added Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch. labels Feb 14, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

agocke and others added 6 commits February 13, 2020 17:09
The changes made in #41123 fix the
GetHashCode for SubstitutedMethodSymbol for more nullability scenarios,
but end up hashing all generic methods with a non-generic containing
type into the same bucket. This can cause large performance regressions
for the compiler.

This change ensures that substituted symbols which have substitutions
equivalent to their original methods' type parameter continue to be
equal, but substituted methods with different type substitutions are not
considered equal.
…213.6 (#41694)

- Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20113.6
* Add double checked locking for AdditionalTextFile.GetText.

* Use LazyInitializer

* Use Lazy instead of LazyInitializer

* Make _text readonly
* Annotate NamespaceOrTypeSymbol

* Annotate public model for NamespaceOrTypeSymbol
@dotnet-bot dotnet-bot requested a review from a team as a code owner February 14, 2020 18:22
@ghost ghost merged commit 35cfcfc into features/local-function-attributes Feb 14, 2020
@ghost ghost deleted the merges/master-to-features/local-function-attributes branch February 14, 2020 19:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure auto-merge Merge Conflicts There are merge conflicts with the base branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants