Skip to content

Merge release/dev16.5 to release/dev16.5-vs-deps #41685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Feb 14, 2020
Merged

Merge release/dev16.5 to release/dev16.5-vs-deps #41685

1 commit merged into from
Feb 14, 2020

Conversation

@dotnet-bot
Copy link
Collaborator

@dotnet-bot dotnet-bot commented Feb 14, 2020

This is an automatically generated pull request from release/dev16.5 into release/dev16.5-vs-deps.

git fetch --all
git checkout merges/release/dev16.5-to-release/dev16.5-vs-deps
git reset --hard upstream/release/dev16.5-vs-deps
git merge upstream/release/dev16.5
# Fix merge conflicts
git commit
git push upstream merges/release/dev16.5-to-release/dev16.5-vs-deps --force

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.

@agocke
Improve SubstitutedMethodSymbol.GetHashCode (#41674)
82a17a5 
The changes made in #41123 fix the
GetHashCode for SubstitutedMethodSymbol for more nullability scenarios,
but end up hashing all generic methods with a non-generic containing
type into the same bucket. This can cause large performance regressions
for the compiler.

This change ensures that substituted symbols which have substitutions
equivalent to their original methods' type parameter continue to be
equal, but substituted methods with different type substitutions are not
considered equal.
@dotnet-bot dotnet-bot requested a review from a team as a code owner February 14, 2020 01:48
ghost
ghost approved these changes Feb 14, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 92790e2 into release/dev16.5-vs-deps Feb 14, 2020
@ghost ghost deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 03:00
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 03:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 03:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 06:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 06:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 09:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 09:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 12:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 12:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 15:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 15:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 18:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 18:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 21:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 14, 2020 21:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 00:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 00:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 03:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 03:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 06:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 06:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 09:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 09:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 15, 2020 12:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 06:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 06:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 09:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 09:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 12:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 12:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 15:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 15:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 18:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 18:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 21:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 17, 2020 21:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 00:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 00:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 03:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 03:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 06:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 06:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 09:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 09:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 12:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 12:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 15:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 15:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 18:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 18:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 21:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 18, 2020 21:02
@dotnet-bot dotnet-bot restored the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 19, 2020 00:02
@dotnet-bot dotnet-bot deleted the merges/release/dev16.5-to-release/dev16.5-vs-deps branch February 19, 2020 00:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area-Infrastructure auto-merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotnet-bot @agocke