Merge master to local-function-attributes #41725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-release/dev16.4-vs-deps Merge release/dev16.4 to release/dev16.4-vs-deps
…-release/dev16.4-vs-deps Merge release/dev16.4 to release/dev16.4-vs-deps
…-release/dev16.4-vs-deps Merge release/dev16.4 to release/dev16.4-vs-deps
…-release/dev16.4-vs-deps Merge release/dev16.4 to release/dev16.4-vs-deps
We suppressed these because we were on the .NET Portable profile and thus couldn't do the anything else. We're no longer on the portable profile.
…214.5 (dotnet#41720) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20114.5
RikkiGibson
force-pushed
the
lfa-inlineStatementParsing
branch
from
58eee05 to
b0b39ba
Compare
RikkiGibson
commented
Feb 15, 2020
Member
Author
There was a problem hiding this comment.
I arbitrarily let the name change back to ParseStatementCore, but it can still return null, even if isGlobalScriptLevel is false.
RikkiGibson
commented
Feb 15, 2020
…215.1 (dotnet#41734) - Microsoft.DotNet.Arcade.Sdk - 5.0.0-beta.20115.1
Convert AssignOutParametersAboveReturnTests to the new test framework
Add shared resx files to our shared projects
…rsing Inline statement parsing
RikkiGibson
force-pushed
the
lfa-inlineStatementParsing
branch
from
009de58 to
48e6e55
Compare
RikkiGibson
force-pushed
the
lfa-inlineStatementParsing
branch
from
48e6e55 to
29dadf0
Compare
RikkiGibson
changed the title
Member
Author
|
@dotnet/roslyn-compiler could I please get a second review on the last few commits in this PR (starting with 9a88cd4). |
Member
Author
|
Added a few more tests that were necessary before feature merge and deleted a PROTOTYPE comment. |
jaredpar
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates changes from master including #41585, which requires some manual fixup.
Suggest reviewing commit-by-commit starting with 9a88cd4.