Skip to content

Conversation

@JoeRobich
Copy link
Member

Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1070152

Calling View.SynchronizeClassView using keyboard shortcut is not working anymore.

View.SynchronizeClassView is registered to a keyboard shortcut (Alt+M). The shortcut is not shared with other commands and was working fine with version 16.3.10.

Under 16.4.0, doing the keyboard shortcut is not working anymore. I have no idea if the shortcut system itself is broken or if the call to “View.SynchronizeClassView” is broken.

I’m using the very same solution in my tests between version 16.3.10 (working) and 16.4.0 (not working).

I tried changing the shortcut but the result is still the same, not working.
I only ear a beep sound (ding.wav) and nothing happens.

The change in 8259140 removes code that intercepted availability requests in order to always reply available. The SyncClassView CommandHandler should have been updated to reply accordingly. This fix implements that behavior.

msftbot[bot] and others added 5 commits December 6, 2019 19:39
…-release/dev16.4-vs-deps

Merge release/dev16.4 to release/dev16.4-vs-deps
…-release/dev16.4-vs-deps

Merge release/dev16.4 to release/dev16.4-vs-deps
…-release/dev16.4-vs-deps

Merge release/dev16.4 to release/dev16.4-vs-deps
…-release/dev16.4-vs-deps

Merge release/dev16.4 to release/dev16.4-vs-deps
@JoeRobich JoeRobich requested a review from a team as a code owner February 18, 2020 18:58
@JoeRobich JoeRobich changed the base branch from release/dev16.4-vs-deps to release/dev16.4 February 18, 2020 19:10
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to target this against non-vs-deps so the change does flow into master instead of master-vs-deps.

@JoeRobich JoeRobich mentioned this pull request Feb 18, 2020
@JoeRobich JoeRobich merged commit d27b5a7 into dotnet:release/dev16.4 Feb 19, 2020
@JoeRobich JoeRobich deleted the fix-classview-sync branch March 14, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants