Implement de-duplication of code actions from NuGet and VSIX code fixers #41768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Nuget and VSIX. Implements the code fix de-duping design from dotnet#18818
23 tasks
sharwell
approved these changes
Mar 18, 2020
| string equivalenceKey, | ||
| Dictionary<Diagnostic, PooledHashSet<string>> uniqueDiagosticToEquivalenceKeysMap) | ||
| { | ||
| using var disposer = ArrayBuilder<Diagnostic>.GetInstance(out var newApplicableDiagnostics); |
Contributor
There was a problem hiding this comment.
Suggested change
| using var disposer = ArrayBuilder<Diagnostic>.GetInstance(out var newApplicableDiagnostics); | |
| using var _ = ArrayBuilder<Diagnostic>.GetInstance(out var newApplicableDiagnostics); |
Contributor
Author
There was a problem hiding this comment.
Thanks, will do this as part of a follow-up change.
ghost
modified the milestones:
Merged
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
Jun 1, 2020
…#41768, and described in dotnet#44553 (comment) Verified the test failed without any product change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the code fix part for #18818
First commit adds the unit tests as per the design, and second commit implements the de-duplication in code fix service.