Return null rather than this from INamedTypeSymbol.TupleUnderlyingType
#41828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
INamedTypeSymbol.TupleUnderlyingType
AlekseyTs
reviewed
Feb 20, 2020
| @@ -167,7 +167,7 @@ public interface INamedTypeSymbol : ITypeSymbol | |||
| bool MightContainExtensionMethods { get; } | |||
|
|
|||
| /// <summary> | |||
| /// If this is a tuple type symbol, returns the symbol for its underlying type (ie. without element names). | |||
| /// If this is a tuple type with element names, returns the symbol for the tuple type without names. | |||
There was a problem hiding this comment.
If this is a tuple type with element names, returns the symbol for the tuple type without names. [](start = 12, length = 96)
Is this accurate for long tuples? #Closed
There was a problem hiding this comment.
Yes, that should be correct for long tuples as well.
In reply to: 382318717 [](ancestors = 382318717)
|
It looks like CI isn't passing. #Closed |
|
Done with review pass (iteration 1) #Closed |
AlekseyTs
reviewed
Feb 21, 2020
| @@ -492,6 +491,11 @@ bool containsModopt(INamedTypeSymbol symbol) | |||
| } | |||
| } | |||
|
|
|||
| private static INamedTypeSymbol GetTupleUnderlyingTypeOrSelf(INamedTypeSymbol type) | |||
There was a problem hiding this comment.
private static INamedTypeSymbol GetTupleUnderlyingTypeOrSelf(INamedTypeSymbol type) [](start = 8, length = 83)
It feels like we should be able to share this helper between compilers by adding it to ITypeSymbolHelpers type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41702