Skip to content

Share file header analyzer with the code style layer #42220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sharwell merged 1 commit into from
Mar 6, 2020
Merged

Share file header analyzer with the code style layer #42220

sharwell merged 1 commit into from
Mar 6, 2020

Conversation

@sharwell
Copy link
Contributor

@sharwell sharwell commented Mar 6, 2020

No description provided.

@sharwell sharwell requested a review from a team as a code owner March 6, 2020 18:25
sharwell
sharwell commented Mar 6, 2020
View reviewed changes
src/Analyzers/CSharp/CodeFixes/FileHeaders/CSharpFileHeaderCodeFixProvider.cs Outdated
Comment on lines 31 to 35
Copy link
Contributor Author

@sharwell sharwell Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 These were internal methods, so I just reverted a6d62cc and 1afb1c6 to use the original approach.

Copy link
Contributor Author

@sharwell sharwell Mar 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Only EndOfLine was a problem.

@sharwell sharwell changed the title Move file header analyzer to the code style layer Share file header analyzer with the code style layer Mar 6, 2020
CyrusNajmabadi
CyrusNajmabadi approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo @mavasani 's feedback.

mavasani
mavasani approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo switching back to ISyntaxFacts.ParseLeadingTrivia and reverting the added abstract method ParseLeadingTrivia

@mavasani
Copy link
Contributor

mavasani commented Mar 6, 2020 •
edited
Loading

By the way, super excited with the prospect of enabling this analyzer and enforcing headers from CodeStyle NuGet package! @sharwell I think we do want #41687 to go in so we don't see duplicate diagnostics + execution from CodeStyle NuGet and built-in IDE analyzer

@sharwell sharwell force-pushed the shared-file-headers branch from f0a8fca to 4f54c77 Compare March 6, 2020 19:14
@sharwell sharwell merged commit 61ffa90 into dotnet:master Mar 6, 2020
@ghost ghost added this to the Next milestone Mar 6, 2020
@sharwell sharwell deleted the shared-file-headers branch March 6, 2020 21:47
@sharwell sharwell modified the milestones: Next, 16.6.P2 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

+1 more reviewer

@mavasani mavasani mavasani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

16.6.P2

Development

Successfully merging this pull request may close these issues.

3 participants

@sharwell @mavasani @CyrusNajmabadi