Support using local declarations in a Simple Program.
#42385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@cston, @RikkiGibson, @dotnet/roslyn-compiler Please review |
cston
reviewed
Mar 13, 2020
| private bool IsPossibleFirstTypedIdentifierInLocaDeclarationStatement(bool isGlobalScriptLevel) | ||
| { | ||
|
|
||
| bool? typedIdentifier = IsPossibleTypedIdentifierStart(this.CurrentToken, this.PeekToken(1), allowThisKeyword: false); |
Contributor
There was a problem hiding this comment.
Extra blank line. #Resolved
cston
reviewed
Mar 13, 2020
| N(SyntaxKind.EndOfFileToken); | ||
| } | ||
| EOF(); | ||
| } |
Contributor
There was a problem hiding this comment.
} [](start = 8, length = 1)
Consider testing using static type = identifier;. #Resolved
cston
approved these changes
Mar 13, 2020
Contributor
Author
|
@RikkiGibson, @dotnet/roslyn-compiler Please review, need a second sign-off for a fairly small change. |
RikkiGibson
reviewed
Mar 13, 2020
|
|
||
| if (IsDeclarationModifier(tk)) // treat `const int x = 2;` as a local variable declaration | ||
| { | ||
| if (tk != SyntaxKind.StaticKeyword) // For `static` we still need to make sure we have a typed dentifier after it, because `using static type;` is a valid using directive. |
Member
There was a problem hiding this comment.
nit: typed *identifier #Resolved
RikkiGibson
reviewed
Mar 13, 2020
| } | ||
| } | ||
| else if ((SyntaxFacts.IsPredefinedType(tk) && | ||
| this.PeekToken(1).Kind != SyntaxKind.DotToken && // e.g. `int.Parse()` is an expression |
Member
There was a problem hiding this comment.
should this use 'tk' instead? #Resolved
Contributor
Author
There was a problem hiding this comment.
should this use 'tk' instead?
Good catch, that should peek at the next token instead, i.e. 2.
In reply to: 392430189 [](ancestors = 392430189)
RikkiGibson
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41704.