Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CFG for new pattern forms #42548

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Implement CFG for new pattern forms #42548

merged 1 commit into from
Mar 20, 2020

Conversation

gafter
Copy link
Member

@gafter gafter commented Mar 18, 2020

No description provided.

@gafter gafter self-assigned this Mar 18, 2020
@gafter gafter added this to the Compiler.Net5 milestone Mar 18, 2020
@gafter gafter mentioned this pull request Mar 18, 2020
Merged
@gafter gafter requested review from RikkiGibson and agocke March 19, 2020 16:26
@gafter gafter marked this pull request as ready for review March 19, 2020 16:26
@gafter gafter requested a review from a team as a code owner March 19, 2020 16:26
@gafter
Copy link
Member Author

gafter commented Mar 19, 2020

@agocke @RikkiGibson @dotnet/roslyn-compiler Would you please review this change to provide CFG support for the new pattern forms?

@gafter gafter mentioned this pull request Mar 19, 2020
Closed
18 tasks
@333fred 333fred requested a review from AlekseyTs March 19, 2020 17:36
@333fred 333fred self-assigned this Mar 19, 2020
@333fred 333fred removed their assignment Mar 19, 2020
AlekseyTs
AlekseyTs approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (iteration 1)

@gafter gafter merged commit 6af9045 into dotnet:features/patterns3 Mar 20, 2020
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Apr 14, 2020
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred 333fred approved these changes

@RikkiGibson RikkiGibson Awaiting requested review from RikkiGibson

@agocke agocke Awaiting requested review from agocke

Assignees

@gafter gafter

Labels
Area-Compilers Feature - Pattern Matching Pattern Matching
Projects
None yet
Milestone
Compiler.Net5
Development

Successfully merging this pull request may close these issues.
3 participants
@gafter @333fred @AlekseyTs