Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Analyzers/CSharp/Analyzers/CSharpAnalyzers.projitems
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@
<Compile Include="$(MSBuildThisFileDirectory)RemoveUnreachableCode\RemoveUnreachableCodeHelpers.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\CSharpUseCoalesceExpressionForNullableDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\CSharpUseCompoundAssignmentDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\CSharpUseCompoundCoalesceAssignmentDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\Utilities.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\CSharpUseConditionalExpressionForAssignmentDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\CSharpUseConditionalExpressionForReturnDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseDeconstruction\CSharpUseDeconstructionDiagnosticAnalyzer.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ internal class CSharpUseCompoundCoalesceAssignmentDiagnosticAnalyzer
public CSharpUseCompoundCoalesceAssignmentDiagnosticAnalyzer()
: base(IDEDiagnosticIds.UseCoalesceCompoundAssignmentDiagnosticId,
CodeStyleOptions2.PreferCompoundAssignment,
new LocalizableResourceString(nameof(FeaturesResources.Use_compound_assignment), FeaturesResources.ResourceManager, typeof(FeaturesResources)))
new LocalizableResourceString(nameof(AnalyzersResources.Use_compound_assignment), AnalyzersResources.ResourceManager, typeof(AnalyzersResources)))
{
}

Expand Down
2 changes: 2 additions & 0 deletions src/Analyzers/CSharp/CodeFixes/CSharpCodeFixes.projitems
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
<Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedMembers\CSharpRemoveUnusedMembersCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\CSharpRemoveUnusedValuesCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\CSharpUseCollectionInitializerCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\CSharpUseCompoundAssignmentCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\CSharpUseCompoundCoalesceAssignmentCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\CSharpUseConditionalExpressionForAssignmentCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\CSharpUseConditionalExpressionForReturnCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\MultiLineConditionalExpressionFormattingRule.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ protected override async Task FixAllAsync(
}
}

private class MyCodeAction : CodeAction.DocumentChangeAction
private class MyCodeAction : CustomCodeActions.DocumentChangeAction
{
public MyCodeAction(Func<CancellationToken, Task<Document>> createChangedDocument)
: base(FeaturesResources.Use_compound_assignment, createChangedDocument, FeaturesResources.Use_compound_assignment)
: base(AnalyzersResources.Use_compound_assignment, createChangedDocument, AnalyzersResources.Use_compound_assignment)
{
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
<Compile Include="$(MSBuildThisFileDirectory)RemoveUnreachableCode\RemoveUnreachableCodeTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\UseCompoundAssignmentTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\UseCompoundCoalesceAssignmentTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\UseConditionalExpressionForAssignmentTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\UseConditionalExpressionForReturnTests.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseDeconstruction\UseDeconstructionTests.cs" />
Expand Down
2 changes: 2 additions & 0 deletions src/Analyzers/Core/Analyzers/Analyzers.projitems
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractObjectCreationExpressionAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractUseCollectionInitializerDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\ObjectCreationExpressionAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\AbstractUseCompoundAssignmentDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\UseCompoundAssignmentUtilities.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\AbstractUseConditionalExpressionDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\ForAssignment\AbstractUseConditionalExpressionForAssignmentDiagnosticAnalyzer.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\ForAssignment\UseConditionalExpressionForAssignmentHelpers.cs" />
Expand Down
3 changes: 3 additions & 0 deletions src/Analyzers/Core/Analyzers/AnalyzersResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,9 @@
<data name="Use_explicitly_provided_tuple_name" xml:space="preserve">
<value>Use explicitly provided tuple name</value>
</data>
<data name="Use_compound_assignment" xml:space="preserve">
<value>Use compound assignment</value>
</data>
<data name="Use_null_propagation" xml:space="preserve">
<value>Use null propagation</value>
</data>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ protected AbstractUseCompoundAssignmentDiagnosticAnalyzer(
: base(IDEDiagnosticIds.UseCompoundAssignmentDiagnosticId,
CodeStyleOptions2.PreferCompoundAssignment,
new LocalizableResourceString(
nameof(FeaturesResources.Use_compound_assignment), FeaturesResources.ResourceManager, typeof(FeaturesResources)))
nameof(AnalyzersResources.Use_compound_assignment), AnalyzersResources.ResourceManager, typeof(AnalyzersResources)))
{
_syntaxFacts = syntaxFacts;
UseCompoundAssignmentUtilities.GenerateMaps(kinds, out _binaryToAssignmentMap, out _assignmentToTokenMap);
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.cs.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.de.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.es.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.fr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.it.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.ja.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.ko.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.pl.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.pt-BR.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.ru.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
5 changes: 5 additions & 0 deletions src/Analyzers/Core/Analyzers/xlf/AnalyzersResources.tr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,11 @@
<target state="new">Use coalesce expression</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="new">Use compound assignment</target>
<note />
</trans-unit>
<trans-unit id="Use_explicitly_provided_tuple_name">
<source>Use explicitly provided tuple name</source>
<target state="new">Use explicitly provided tuple name</target>
Expand Down
1 change: 1 addition & 0 deletions src/Analyzers/Core/CodeFixes/CodeFixes.projitems
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\AbstractUseCollectionInitializerCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\AbstractUseCompoundAssignmentCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\AbstractUseConditionalExpressionCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\ForAssignment\AbstractUseConditionalExpressionForAssignmentCodeFixProvider.cs" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\ForReturn\AbstractUseConditionalExpressionForReturnCodeFixProvider.cs" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ protected override Task FixAllAsync(
return Task.CompletedTask;
}

private class MyCodeAction : CodeAction.DocumentChangeAction
private class MyCodeAction : CustomCodeActions.DocumentChangeAction
{
public MyCodeAction(Func<CancellationToken, Task<Document>> createChangedDocument)
: base(FeaturesResources.Use_compound_assignment, createChangedDocument, FeaturesResources.Use_compound_assignment)
: base(AnalyzersResources.Use_compound_assignment, createChangedDocument, AnalyzersResources.Use_compound_assignment)
{
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\VisualBasicUseCoalesceExpressionDiagnosticAnalyzer.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\VisualBasicUseCoalesceExpressionForNullableDiagnosticAnalyzer.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\VisualBasicUseCollectionInitializerDiagnosticAnalyzer.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\Utilities.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\VisualBasicUseCompoundAssignmentDiagnosticAnalyzer.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\VisualBasicUseConditionalExpressionForAssignmentDiagnosticAnalyzer.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\VisualBasicUseConditionalExpressionForReturnDiagnosticAnalyzer.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseIsNullCheck\VisualBasicUseIsNullCheckForReferenceEqualsDiagnosticAnalyzer.vb" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedMembers\VisualBasicRemoveUnusedMembersCodeFixProvider.vb" />
<Compile Include="$(MSBuildThisFileDirectory)RemoveUnusedParametersAndValues\VisualBasicRemoveUnusedValuesCodeFixProvider.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\VisualBasicUseCollectionInitializerCodeFixProvider.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\VisualBasicUseCompoundAssignmentCodeFixProvider.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\MultiLineConditionalExpressionFormattingRule.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\VisualBasicUseConditionalExpressionForAssignmentCodeFixProvider.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\VisualBasicUseConditionalExpressionForReturnCodeFixProvider.vb" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionForNullableTests.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCoalesceExpression\UseCoalesceExpressionTests.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCollectionInitializer\UseCollectionInitializerTests.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseCompoundAssignment\UseCompoundAssignmentTests.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\UseConditionalExpressionForAssignmentTests.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseConditionalExpression\UseConditionalExpressionForReturnTests.vb" />
<Compile Include="$(MSBuildThisFileDirectory)UseIsNullCheck\UseIsNullCheckForReferenceEqualsTests.vb" />
Expand Down
3 changes: 0 additions & 3 deletions src/Features/Core/Portable/FeaturesResources.resx
Original file line number Diff line number Diff line change
Expand Up @@ -1249,9 +1249,6 @@ This version used in: {2}</value>
<data name="Warning_colon_changing_namespace_may_produce_invalid_code_and_change_code_meaning" xml:space="preserve">
<value>Warning: Changing namespace may produce invalid code and change code meaning.</value>
</data>
<data name="Use_compound_assignment" xml:space="preserve">
<value>Use compound assignment</value>
</data>
<data name="Invert_conditional" xml:space="preserve">
<value>Invert conditional</value>
</data>
Expand Down
5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.cs.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,6 @@
<target state="translated">Pro lambda výrazy používat text bloku</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="translated">Použít složené přiřazení</target>
<note />
</trans-unit>
<trans-unit id="Use_expression_body_for_lambda_expressions">
<source>Use expression body for lambda expressions</source>
<target state="translated">Používat text výrazu pro lambda výrazy</target>
Expand Down
5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.de.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,6 @@
<target state="translated">Blocktextkörper für Lambdaausdrücke verwenden</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="translated">Verbundzuweisung verwenden</target>
<note />
</trans-unit>
<trans-unit id="Use_expression_body_for_lambda_expressions">
<source>Use expression body for lambda expressions</source>
<target state="translated">Ausdruckskörper für Lambdaausdrücke verwenden</target>
Expand Down
5 changes: 0 additions & 5 deletions src/Features/Core/Portable/xlf/FeaturesResources.es.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -617,11 +617,6 @@
<target state="translated">Usar cuerpo del bloque para las expresiones lambda</target>
<note />
</trans-unit>
<trans-unit id="Use_compound_assignment">
<source>Use compound assignment</source>
<target state="translated">Usar la asignación compuesta</target>
<note />
</trans-unit>
<trans-unit id="Use_expression_body_for_lambda_expressions">
<source>Use expression body for lambda expressions</source>
<target state="translated">Usar órgano de expresión para expresiones lambda</target>
Expand Down
Loading