Fix override completion to preserve added imports #43173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Why does that cause a regression? |
src/Features/Core/Portable/Completion/Providers/AbstractMemberInsertingCompletionProvider.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/Completion/Providers/AbstractMemberInsertingCompletionProvider.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Apr 8, 2020
genlu
force-pushed
the
FixOverrideCompletion
branch
from
31ce544 to
1dd0407
Compare
Member
Author
|
Retargeting to 16.6 since this is a regression. |
Member
Author
|
This is approved for 16.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #39909
The regression is caused by adding simplifier annotation to added imports (https://github.com/dotnet/roslyn/blob/master/src/Workspaces/Core/Portable/Editing/ImportAdderService.cs#L137)