Skip to content

Merge release/dev16.6 to release/dev16.6-vs-deps #43196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
16 commits merged into from
Apr 9, 2020
Merged

Merge release/dev16.6 to release/dev16.6-vs-deps #43196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7ff0078
Set Microsoft.CodeAnalysis.Analyzers package to a release version
JoeRobich Apr 2, 2020
a11d085
Surpress RS2008
JoeRobich Apr 2, 2020
c41812a
Handle RS1030 diagnostic
JoeRobich Apr 7, 2020
737253f
Remove suppression of RS1030
JoeRobich Apr 7, 2020
d6ffb54
Fix RS1030 (Do not invoke Compilation.GetSemanticModel() method withi…
sharwell Mar 17, 2020
17b7351
Suppress RS1030 where no other option is available
sharwell Mar 17, 2020
8835230
Suppress RS2008 for .cs and .vb files
JoeRobich Apr 7, 2020
f5a49d3
Fix Make Field Readonly handling of ref return values
sharwell Apr 7, 2020
973d5a4
Merge pull request #43006 from JoeRobich/set-package-version
JoeRobich Apr 8, 2020
4402e33
Merge pull request #36272 from sharwell/track-ref-returns
sharwell Apr 8, 2020
3667e0d
Merge remote-tracking branch 'origin/release/dev16.6' into merges/rel…
JoeRobich Apr 8, 2020
e9bd9cb
Update color scheme on package initialization.
JoeRobich Apr 8, 2020
fa1771f
Add comment about why we update color scheme on initialize
JoeRobich Apr 8, 2020
9e21d4d
Merge pull request #43193 from dotnet/merges/release/dev16.5-to-relea…
JoeRobich Apr 8, 2020
4e5a229
Reduce stack frame size of CheckConstraints (#43094)
cston Apr 8, 2020
007c46d
Merge pull request #43200 from dotnet/dev/jorobich/apply-colors-on-in…
JoeRobich Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,9 @@ dotnet_naming_symbols.all_members.applicable_kinds = *

dotnet_naming_style.pascal_case_style.capitalization = pascal_case

# error RS2008: Enable analyzer release tracking for the analyzer project containing rule '{0}'
dotnet_diagnostic.RS2008.severity = none

# IDE0073: File header
dotnet_diagnostic.IDE0073.severity = warning
file_header_template = Licensed to the .NET Foundation under one or more agreements.\nThe .NET Foundation licenses this file to you under the MIT license.\nSee the LICENSE file in the project root for more information.
Expand Down
21 changes: 13 additions & 8 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<PatchVersion>0</PatchVersion>
<PreReleaseVersionLabel>3</PreReleaseVersionLabel>
<VersionPrefix>$(MajorVersion).$(MinorVersion).$(PatchVersion)</VersionPrefix>
<!--
<!--
By default the assembly version in official builds is "$(MajorVersion).$(MinorVersion).0.0".
Keep the setting conditional. The toolset sets the assembly version to 42.42.42.42 if not set explicitly.
-->
Expand All @@ -35,7 +35,7 @@
<ILToolsPackageVersion>5.0.0-alpha1.19409.1</ILToolsPackageVersion>
<MicrosoftVisualStudioLanguageServerPackagesVersion>16.3.27-develop-gdd55e997</MicrosoftVisualStudioLanguageServerPackagesVersion>
</PropertyGroup>
<!--
<!--
Dependency versions
-->
<PropertyGroup>
Expand All @@ -54,7 +54,12 @@
<MicrosoftBuildLocatorVersion>1.2.2</MicrosoftBuildLocatorVersion>
<MicrosoftBuildRuntimeVersion>15.3.409</MicrosoftBuildRuntimeVersion>
<MicrosoftBuildTasksCoreVersion>15.3.409</MicrosoftBuildTasksCoreVersion>
<MicrosoftCodeAnalysisAnalyzersVersion>$(RoslynDiagnosticsNugetPackageVersion)</MicrosoftCodeAnalysisAnalyzersVersion>
<!--
Since the Microsoft.CodeAnalysis.Analyzers package is a public dependency of our NuGet
packages we will keep it untied to the RoslynDiagnosticsNugetPackageVersion we use for
other analyzers to ensure it stays on a release version.
-->
<MicrosoftCodeAnalysisAnalyzersVersion>3.0.0</MicrosoftCodeAnalysisAnalyzersVersion>
<MicrosoftCodeAnalysisBuildTasksVersion>2.0.0-rc2-61102-09</MicrosoftCodeAnalysisBuildTasksVersion>
<MicrosoftCodeAnalysisCSharpCodeFixTestingXUnitVersion>$(MicrosoftCodeAnalysisTestingVersion)</MicrosoftCodeAnalysisCSharpCodeFixTestingXUnitVersion>
<MicrosoftCodeAnalysisCSharpCodeStyleVersion>$(CodeStyleAnalyzerVersion)</MicrosoftCodeAnalysisCSharpCodeStyleVersion>
Expand Down Expand Up @@ -241,9 +246,9 @@
<MicrosoftVisualStudioStaticReviewsEmbeddableVersion>0.1.102-alpha</MicrosoftVisualStudioStaticReviewsEmbeddableVersion>
<MicrosoftBclAsyncInterfacesVersion>1.1.0</MicrosoftBclAsyncInterfacesVersion>
</PropertyGroup>
<!--
The following packages are considered implementation details and will not be included
in the list of dependencies of Roslyn packages. They won't flow as package references
<!--
The following packages are considered implementation details and will not be included
in the list of dependencies of Roslyn packages. They won't flow as package references
to the projects that reference Roslyn packages.
-->
<ItemGroup>
Expand Down Expand Up @@ -321,9 +326,9 @@
<UsingToolXliff>true</UsingToolXliff>
<UsingToolXUnit>true</UsingToolXUnit>
<DiscoverEditorConfigFiles>true</DiscoverEditorConfigFiles>
<!--
<!--
When using a bootstrap builder we don't want to use the Microsoft.Net.Compilers.Toolset package but
rather explicitly override it.
rather explicitly override it.
-->
<UsingToolMicrosoftNetCompilers Condition="'$(BootstrapBuildPath)' == ''">true</UsingToolMicrosoftNetCompilers>
</PropertyGroup>
Expand Down
Loading