Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test new pattern forms in interactive. #43358

Merged
merged 2 commits into from
Apr 15, 2020
Merged

Test new pattern forms in interactive. #43358

merged 2 commits into from
Apr 15, 2020

Conversation

gafter
Copy link
Member

@gafter gafter commented Apr 14, 2020

No description provided.

@gafter gafter added this to the Compiler.Net5 milestone Apr 14, 2020
@gafter gafter requested review from tmat and a team April 14, 2020 23:51
@gafter gafter requested review from a team as code owners April 14, 2020 23:51
@gafter gafter self-assigned this Apr 14, 2020
@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Apr 14, 2020
Closed
29 tasks
@gafter
Copy link
Member Author

gafter commented Apr 14, 2020

@RikkiGibson @agocke Could one of you please look at this newly added unit test?

jcouv
jcouv approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 2)

@jcouv jcouv self-assigned this Apr 14, 2020
@gafter gafter merged commit 505e6bf into dotnet:features/patterns3 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@tmat tmat Awaiting requested review from tmat

Assignees

@gafter gafter

@jcouv jcouv

Labels
Area-Compilers Feature - Pattern Matching Pattern Matching Interactive-ScriptingLogic
Projects
None yet
Milestone
Compiler.Net5
Development

Successfully merging this pull request may close these issues.
3 participants
@gafter @CyrusNajmabadi @jcouv