Skip to content

Fixed IDE0044 (Make Field Readonly) for DataMember fields in DataContract classes #43489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 14, 2022
Merged

Fixed IDE0044 (Make Field Readonly) for DataMember fields in DataContract classes #43489

merged 4 commits into from
Feb 14, 2022

Conversation

@zaytsev-victor
Copy link
Contributor

@zaytsev-victor zaytsev-victor commented Apr 19, 2020

Fixes #40644

@zaytsev-victor zaytsev-victor requested a review from a team as a code owner April 19, 2020 17:38
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Apr 22, 2020
sharwell
sharwell suggested changes Jun 23, 2020
View reviewed changes
Base automatically changed from master to main March 3, 2021 23:52
@Youssef1313
Copy link
Member

Youssef1313 commented Jan 21, 2022

@zaytsev-victor Would you like to address the review comments?

@sharwell
Copy link
Contributor

sharwell commented Jan 21, 2022 •
edited
Loading

If not, this PR is small enough that we can probably make the corrections to it and prepare it for merge. Let us know which you prefer.

@zaytsev-victor zaytsev-victor requested a review from a team as a code owner February 4, 2022 23:54
@runfoapp runfoapp bot mentioned this pull request Feb 7, 2022
Closed
@sharwell sharwell enabled auto-merge February 8, 2022 19:08
@dotnet dotnet deleted a comment from azure-pipelines bot Feb 8, 2022
RikkiGibson
RikkiGibson approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@RikkiGibson RikkiGibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler changes LGTM. The changes are test-only so I think only one compiler review is needed.

@sharwell sharwell merged commit c74fc4e into dotnet:main Feb 14, 2022
@ghost ghost added this to the Next milestone Feb 14, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P2 Mar 1, 2022
@sharwell sharwell added the Feature - IDE0044 Make field readonly label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikkiGibson RikkiGibson RikkiGibson approved these changes

+1 more reviewer

@sharwell sharwell sharwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sharwell sharwell

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - IDE0044 Make field readonly

Projects

None yet

Milestone

17.2.P2

Development

Successfully merging this pull request may close these issues.

IDE0044 (Make Field Readonly) Should not warn for DataMember fields in DataContract classes

5 participants

@zaytsev-victor @Youssef1313 @sharwell @RikkiGibson @jinujoseph