Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation remarks for syntax kinds #43646

Merged
merged 4 commits into from
Sep 15, 2020

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Apr 24, 2020

This is a proposal for additional documentation remarks for syntax nodes and IOperation interfaces.

image

Related to #43647

@sharwell sharwell marked this pull request as ready for review May 1, 2020 06:58
@sharwell sharwell requested a review from a team as a code owner May 1, 2020 06:58
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@jcouv jcouv self-assigned this Jul 22, 2020
@dotnet dotnet deleted a comment from azure-pipelines bot Jul 23, 2020
@jcouv jcouv closed this Sep 15, 2020
@jcouv jcouv reopened this Sep 15, 2020
@jcouv jcouv merged commit 5f0b751 into dotnet:master Sep 15, 2020
@ghost ghost added this to the Next milestone Sep 15, 2020
333fred added a commit to 333fred/roslyn that referenced this pull request Sep 17, 2020
* upstream/master: (114 commits)
  Remove langversion restriction for source generators. (dotnet#47714)
  Adjust disambiguation rules for type pattern in a switch expression. (dotnet#47756)
  Delete decommissioned benchview tool scripts (dotnet#47752)
  Emit conversions between native integers and pointers directly (dotnet#47708)
  Typeless expressions should contribute nullability to lambda return (dotnet#47581)
  Use a distinct diagnostic ID when an exhaustiveness report uses an unnamed enum value. (dotnet#47693)
  [master] Update dependencies from dotnet/arcade (dotnet#46586)
  Change `Location` of record's primary constructor to point to record's identifier. (dotnet#47715)
  Add public API test for extended partial methods (dotnet#47727)
  Rename in CheckValidNullableMethodOverride (dotnet#47718)
  Update docs
  Add more doc comments
  Add comments and doc comments for ExternalErrorDiagnosticUpdateSource
  Add documentation remarks for syntax kinds (dotnet#43646)
  Disable TestCancellation (dotnet#47725)
  Classify function pointer punctuation (dotnet#47668)
  Disable flaky optprof test
  Handle NotNullIfNotNull in delegate creation and overrides (dotnet#47572)
  Adjust QuickInfo on record BaseType syntax (dotnet#47656)
  Don't exclude events for NameOf context
  ...
@sharwell sharwell deleted the syntax-kind-remarks branch September 17, 2020 02:41
@dibarbet dibarbet modified the milestones: Next, 16.8.P4 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants