Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude csc.exe from optprof profiling #43853

Merged
merged 1 commit into from
May 8, 2020
Merged

Exclude csc.exe from optprof profiling #43853

merged 1 commit into from
May 8, 2020

Conversation

genlu
Copy link
Member

@genlu genlu commented Apr 30, 2020

csc.exe isn't used for build in VS

@chsienki @dotnet/roslyn-infrastructure

@genlu genlu requested a review from a team as a code owner April 30, 2020 23:13
@chsienki
Copy link
Contributor

Are we sure it isn't used? There are definitely RPS scenarios that exercise it (we create data for it, so something must be hitting it).

@genlu
Copy link
Member Author

genlu commented Apr 30, 2020

@agocke said vbcscompiler is used by default in VS build scenario. And I checked our private run, csc.exe doesn't produce any data there either.
https://devdiv.visualstudio.com/_apps/hub/ms-vscs-artifact.build-tasks.drop-hub-group-explorer-hub?name=OptimizationData/dotnet/roslyn/release/dev16.7-preview1-vs-deps/20200430.1/661630/1

@chsienki
Copy link
Contributor

chsienki commented May 1, 2020

Ok, I guess it was previously incorrectly being used.

@genlu genlu closed this May 3, 2020
@genlu genlu reopened this May 3, 2020
@genlu genlu changed the base branch from release/dev16.7-preview1 to master May 4, 2020 20:41
@genlu
Copy link
Member Author

genlu commented May 7, 2020

@JoeRobich It seems github is having some issue with CI status. All the checks are passed if you go to "checks" tab, but the status stuck as incompleted. Could you please just force merge it?

@JoeRobich
Copy link
Member

Passing CI - https://dev.azure.com/dnceng/public/_build/results?buildId=625871&view=results
Passing Integration CI - https://dev.azure.com/dnceng/public/_build/results?buildId=630583&view=results

GitHub checks haven't updated but PR passed CI checks. Merging.

@JoeRobich JoeRobich merged commit 458b0de into dotnet:master May 8, 2020
@ghost ghost added this to the Next milestone May 8, 2020
@JoeRobich JoeRobich modified the milestones: Next, 16.7.P2 May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
16.7.P2
Development

Successfully merging this pull request may close these issues.
3 participants
@genlu @chsienki @JoeRobich