Remove unnecessary DoEvents call #44013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| internal static Task WaitAllDispatcherOperationAndTasksAsync(this IAsynchronousOperationListenerProvider provider, params string[] featureNames) | ||
| => ((AsynchronousOperationListenerProvider)provider).WaitAllAsync(featureNames, eventProcessingAction: () => Dispatcher.CurrentDispatcher.DoEvents()); | ||
| => ((AsynchronousOperationListenerProvider)provider).WaitAllAsync(featureNames); |
Member
There was a problem hiding this comment.
The belief is the DoEvents isn't necessary because we should be yielding the thread no matter what given this is Task?
Contributor
Author
There was a problem hiding this comment.
The DoEvents is not necessary because we're going through JTF which tracks UI thread work requests internally.
Contributor
Author
There was a problem hiding this comment.
📝 I looked into simplifying this further, but I had less confidence in correctness as it fanned out. This seems like a reasonable intermediate perf win.
jasonmalinowski
approved these changes
May 12, 2020
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes some tests faster locally; submitting this PR to see if it causes problems for any others.