[Dogfooding] Enforce few more code style rules as build warnings in IDE projects #44164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…warning for IDE projects (CodeStyle, Features and Workspaces layers)
# IDE0011: Add braces csharp_prefer_braces = when_multiline:warning # IDE0035: Remove unreachable code dotnet_diagnostic.IDE0035.severity = warning # IDE0059: Unnecessary assignment to a value dotnet_diagnostic.IDE0059.severity = warning
… value (we do not offer code fixes to remove such assignments which could have side effects)
mavasani
changed the title
…is options collection in master branch, but my prior commit in this PR attempted to use it in the test. This leads the test to fail, so I have restored the original semantics of the test and removed an unused local.
JoeRobich
approved these changes
May 12, 2020
| @@ -106,7 +106,6 @@ public override Task RegisterCodeFixesAsync(CodeFixContext context) | |||
| var declaratorLocation = diagnostic.AdditionalLocations[0]; | |||
| var identifierLocation = diagnostic.AdditionalLocations[1]; | |||
| var invocationOrCreationLocation = diagnostic.AdditionalLocations[2]; | |||
| var outArgumentContainingStatementLocation = diagnostic.AdditionalLocations[3]; | |||
There was a problem hiding this comment.
shoudl probably fix the analzer to not provide this either.
There was a problem hiding this comment.
@CyrusNajmabadi addressed in d256ecd
| // Invocations definitely have side effects. So we assume this | ||
| // is invalid initially; | ||
| expressionType = ExpressionType.Invalid; | ||
| #pragma warning restore IDE0059 // Unnecessary assignment of a value |
There was a problem hiding this comment.
I am actually not sure if this would cause any side effects, especially given the comment. Just playing safe.
| @@ -33,7 +33,7 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Simplification | |||
| Public Sub Initialize(parseOptions As ParseOptions, optionSet As OptionSet, cancellationToken As CancellationToken) Implements IReductionRewriter.Initialize | |||
| Me.ParseOptions = DirectCast(parseOptions, VisualBasicParseOptions) | |||
| _simplificationOptions = optionSet | |||
| cancellationToken = cancellationToken | |||
| Me.CancellationToken = cancellationToken | |||
CyrusNajmabadi
approved these changes
May 12, 2020
ghost
modified the milestones:
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
May 12, 2020
mavasani
added a commit
to mavasani/roslyn
that referenced
this pull request
May 13, 2020
… IDE projects My prior attempt to enable this as a build warning in dotnet#44164 did not work due to dotnet#44201. This PR actually adds the build enforcement and fixes the violations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #43394