Fix typos and link in Source Generators cookbook #44372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamgauthier
commented
May 19, 2020
Contributor
Author
There was a problem hiding this comment.
I wasn't exactly sure if I needed to re-arrange the entire paragraph here since this makes this line much longer. There seems to be inconsistent style throughout the file where some paragraphs are trimmed at ~90 characters. Either way the rendered markdown doesn't seem to be affected.
chsienki
approved these changes
Jul 14, 2020
Improve mention of IDE experience scenario so that it links to it. Acknowledge trailing JSON comma. Fix FileTransformGenerator example indent.
adamgauthier
force-pushed
the
source-generators-cookbook-fixes
branch
from
4767b2a to
a43802e
Compare
Member
|
Thanks @louistio! Apologies for the delay in getting this merged |
ghost
added this to the
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 17, 2020
* upstream/master: (86 commits) Better client / server logging (dotnet#46079) Fix OptProf config Update src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs Do not execute RemoveUnnecessaryInlineSuppressions on generated code Update dependencies from https://github.com/dotnet/arcade build 20200715.6 (dotnet#46086) Use ISpanMapper before sending cross file results to LSP Add additional module initializers tests from review (dotnet#46020) Fix type in OptProf configuration bump to 500 Fixed VS crash during implicit conversion of null object in nullable walker (dotnet#45974) Rename variable Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer Check modifiers on record positional members (dotnet#45898) Fix typos and link in Source Generators cookbook (dotnet#44372) Remove reference to non-existing VisualStudioInteractiveComponents.vsix from deployment VSIX. (dotnet#45979) Address feedback + fix tests Update dependencies from https://github.com/dotnet/roslyn build 20200711.1 (dotnet#45932) Make MetadataTypeName non-copyable Fix usage of GetService extension Consolidate service provider extensions ...
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Jul 23, 2020
…to function-pointer-type-lookup * upstream/features/function-pointers: (86 commits) Better client / server logging (dotnet#46079) Fix OptProf config Update src/VisualStudio/LiveShare/Impl/AbstractGoToDefinitionWithFindUsagesServiceHandler.cs Do not execute RemoveUnnecessaryInlineSuppressions on generated code Update dependencies from https://github.com/dotnet/arcade build 20200715.6 (dotnet#46086) Use ISpanMapper before sending cross file results to LSP Add additional module initializers tests from review (dotnet#46020) Fix type in OptProf configuration bump to 500 Fixed VS crash during implicit conversion of null object in nullable walker (dotnet#45974) Rename variable Fix KeyNotFound exception in RemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer Check modifiers on record positional members (dotnet#45898) Fix typos and link in Source Generators cookbook (dotnet#44372) Remove reference to non-existing VisualStudioInteractiveComponents.vsix from deployment VSIX. (dotnet#45979) Address feedback + fix tests Update dependencies from https://github.com/dotnet/roslyn build 20200711.1 (dotnet#45932) Make MetadataTypeName non-copyable Fix usage of GetService extension Consolidate service provider extensions ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve mention of IDE experience scenario so that it links to it.
Acknowledge trailing JSON comma. Fix FileTransformGenerator example
indent.