Simplify the helpers we use in symbol finding #44467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
May 21, 2020
Member
Author
There was a problem hiding this comment.
redundant with checks done later.
CyrusNajmabadi
force-pushed
the
simplifyHelpers
branch
5 times, most recently
from
403fb8e to
7e29093
Compare
CyrusNajmabadi
force-pushed
the
simplifyHelpers
branch
from
7e29093 to
5c005e8
Compare
ryzngard
approved these changes
May 21, 2020
Member
Author
|
Thanks! |
ghost
merged commit
This was referenced May 30, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.