Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception in declare-as-nullable code fix #44604

Merged
merged 1 commit into from
Jun 23, 2020
Merged

Fix exception in declare-as-nullable code fix #44604

merged 1 commit into from
Jun 23, 2020

Conversation

dymanoid
Copy link
Contributor

Fixes #44338

IParameterSymbol.DeclaringSyntaxReferences will be empty if the analyzed method call is targeting a method with no source code available (external assembly).

IParameterSymbol.DeclaringSyntaxReferences will be empty if the analyzed
method call is targeting a method with no source code available (external assembly).
@dymanoid dymanoid requested a review from a team as a code owner May 27, 2020 22:44
@dnfclas
Copy link

dnfclas commented May 27, 2020

CLA assistant check
All CLA requirements met.

@dymanoid dymanoid changed the title Fix exception in declare-as-nullable code fix (#44338) Fix exception in declare-as-nullable code fix May 27, 2020
@jinujoseph jinujoseph added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels May 27, 2020
@dymanoid
Copy link
Contributor Author

dymanoid commented Jun 2, 2020

@sharwell Do you have any feedback? Something I need to change? I'd be glad to contribute more!

@sharwell sharwell merged commit c4674ce into dotnet:master Jun 23, 2020
@ghost ghost added this to the Next milestone Jun 23, 2020
@dibarbet dibarbet modified the milestones: Next, 16.7.P4 Jun 30, 2020
@dymanoid dymanoid deleted the declare-as-nullable-code-fix branch July 7, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exceptions from CSharpDeclareAsNullableCodeFixProvider
5 participants