Fix wrong reporting for removing parenthesis for stackalloc #44661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
May 29, 2020
...UtilitiesAndExtensions/Compiler/CSharp/Extensions/ParenthesizedExpressionSyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
Member
no. i mean a comment explaining why we don't want to remove parens here. |
CyrusNajmabadi
approved these changes
May 29, 2020
alrz
reviewed
May 29, 2020
...UtilitiesAndExtensions/Compiler/CSharp/Extensions/ParenthesizedExpressionSyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@CyrusNajmabadi There are test failures now after I moved the test down, can you check where is the problem? things are a bit hard for me to figure, especially that I can't open the sln in Visual Studio. |
Member
|
Yup, this test is failing:
i can try to debug through later to see why. |
Youssef1313
commented
May 30, 2020
...UtilitiesAndExtensions/Compiler/CSharp/Extensions/ParenthesizedExpressionSyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
@CyrusNajmabadi, The unit test was just missing the |
Member
|
Great, thanks! |
ghost
added this to the
jinujoseph
added
Area-IDE
Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44629
@CyrusNajmabadi, Opening
Compilers.slnin Visual Studio makes my laptop hangs and unusable (perhaps because low specs and the solution is very big). So, I really cannot confirm if this fixes it.I'll add relevant unit tests soon.