propagate cancellation tokens #44811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Also tagging @carlossanlop, who is working on analyzer/fixer for this in dotnet/roslyn-analyzers#3641. |
CyrusNajmabadi
approved these changes
Jun 3, 2020
src/Compilers/VisualBasic/Portable/Symbols/Source/SourceModuleSymbol.vb
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
requested changes
Jun 3, 2020
Member
CyrusNajmabadi
left a comment
CyrusNajmabadi
left a comment
There was a problem hiding this comment.
retracting approval until the FatalErrors are undone, or someone who knows more about the subtle distinction there verifies the new pattern is what we want.
mavasani
reviewed
Jun 3, 2020
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerDriver.cs
Outdated
Show resolved
Hide resolved
I am just a simple developer trying to send these cancellation tokens downstream where they belong
jmarolf
force-pushed
the
bugfix/forward-cancellation-tokens
branch
from
5c258e3 to
ce442e7
Compare
CyrusNajmabadi
approved these changes
Jun 3, 2020
ghost
merged commit 
Merged
4 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am just a simple developer trying to send these cancellation tokens downstream where they belong