Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InteractiveHost for .NET Core #45046

Merged
merged 40 commits into from
Jul 13, 2020
Merged

InteractiveHost for .NET Core #45046

merged 40 commits into from
Jul 13, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Jun 10, 2020

Updates Roslyn Setup VSIX to include InteractiveHost for both Desktop and Core CLR.

Removes InteractiveComponents VSIX and uses publishing target in InteractiveHost.csproj instead to gather all files necessary to run InteractiveHost process.

Retargets Microsoft.CodeAnalysis.InteractiveHost to netstandard2.0 and moves Windows and .NET Framework specific logic to InteractiveHost.exe.

Adds a new option to #reset command that allows the user to switch Interactive Window host to .NET Core:

  • #reset 32 - switches to .NET Framework 32-bit process
  • #reset 64 - switches to .NET Framework 64-bit process
  • #reset core - switches to .NET Core 64-bit process

Leaves the default to .NET Framework 64-bit for now.

Fixes #4788
Fixes #5538

@tmat tmat requested review from a team as code owners June 10, 2020 20:39
@tmat
Copy link
Member Author

tmat commented Jun 10, 2020

@jasonmalinowski For VSIX authoring.
@mizuniga

@tmat tmat force-pushed the CoreInteractiveHost168 branch from 26193c6 to 23c1635 Compare June 12, 2020 20:04
@tmat tmat requested a review from a team as a code owner June 16, 2020 03:03
@genlu
Copy link
Member

genlu commented Jun 16, 2020

I'm wondering if the change in optprof config would cause any issue during build: we would miss ibc data for moved assemblies

@tmat tmat force-pushed the CoreInteractiveHost168 branch 3 times, most recently from 86d3197 to 8cbe849 Compare June 26, 2020 20:02
@tmat
Copy link
Member Author

tmat commented Jun 26, 2020

@dotnet/roslyn-ide

eng/config/OptProf.json Outdated Show resolved Hide resolved
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jmarolf
Copy link
Contributor

jmarolf commented Jun 29, 2020

I would do a test insertion of this.

@jasonmalinowski jasonmalinowski self-requested a review June 29, 2020 23:35
@tmat tmat changed the base branch from release/dev16.8-preview1 to master June 30, 2020 02:38
@tmat tmat force-pushed the CoreInteractiveHost168 branch from b9655a9 to 6002797 Compare July 7, 2020 17:31
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments so far; my only real conclusion is I'm not qualified to review this. 😄

@tmat tmat force-pushed the CoreInteractiveHost168 branch 2 times, most recently from b1f7484 to fb80619 Compare July 8, 2020 18:55
@tmat tmat force-pushed the CoreInteractiveHost168 branch from fb80619 to 6e39316 Compare July 9, 2020 23:17
@tmat tmat force-pushed the CoreInteractiveHost168 branch from 6e39316 to efc47e6 Compare July 12, 2020 00:31
@tmat tmat merged commit 4d0c2c0 into dotnet:master Jul 13, 2020
@ghost ghost added this to the Next milestone Jul 13, 2020
@tmat tmat deleted the CoreInteractiveHost168 branch July 13, 2020 17:35
@tmat tmat modified the milestones: Next, 16.8 Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants