-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InteractiveHost for .NET Core #45046
Conversation
@jasonmalinowski For VSIX authoring. |
26193c6
to
23c1635
Compare
I'm wondering if the change in optprof config would cause any issue during build: we would miss ibc data for moved assemblies |
86d3197
to
8cbe849
Compare
@dotnet/roslyn-ide |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do a test insertion of this. |
b9655a9
to
6002797
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments so far; my only real conclusion is I'm not qualified to review this. 😄
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluatorResetOptions.cs
Show resolved
Hide resolved
...s/Core/Implementation/Interactive/Completion/AbstractReferenceDirectiveCompletionProvider.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Core.Wpf/Interactive/InteractiveEvaluator.cs
Outdated
Show resolved
Hide resolved
b1f7484
to
fb80619
Compare
fb80619
to
6e39316
Compare
Simplify keeping search paths in-sync between InteractiveHost and InteractiveEvaluator.
6e39316
to
efc47e6
Compare
Updates Roslyn Setup VSIX to include InteractiveHost for both Desktop and Core CLR.
Removes InteractiveComponents VSIX and uses publishing target in InteractiveHost.csproj instead to gather all files necessary to run InteractiveHost process.
Retargets Microsoft.CodeAnalysis.InteractiveHost to netstandard2.0 and moves Windows and .NET Framework specific logic to
InteractiveHost.exe
.Adds a new option to
#reset
command that allows the user to switch Interactive Window host to .NET Core:#reset 32
- switches to .NET Framework 32-bit process#reset 64
- switches to .NET Framework 64-bit process#reset core
- switches to .NET Core 64-bit processLeaves the default to .NET Framework 64-bit for now.
Fixes #4788
Fixes #5538