-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to features/source-generators #45502
Merged
148 commits merged into
features/source-generators
from
merges/master-to-features/source-generators
Jun 28, 2020
Merged
Merge master to features/source-generators #45502
148 commits merged into
features/source-generators
from
merges/master-to-features/source-generators
Jun 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IParameterSymbol.DeclaringSyntaxReferences will be empty if the analyzed method call is targeting a method with no source code available (external assembly).
… accessors had no references
…he comment more comprehensive
All array types for one elemnt type is consider same in our index. e.g. int[], int[][] and int[,] are just represent as int[]
…reAsNullableCodeFixTests.cs
Since they are already from the same compilation that triggered completion.
…reAsNullableCodeFixTests.cs Co-authored-by: Jason Malinowski <jason@jason-m.com>
…cumentChangedAsync
Include line numbers in Integration Test stack traces
* Introduce LanguageVersion.CSharp9 * Limit netcoreapp3.0, 3.1 and netstdard 2.1 to C# 8.0 * Map CSharp9 to language version preview * Default to CSharp9 for netcoreapp5.0 * Add Tests
Perf improvement for completion of unimported extension methods
Fix inconsistencies in handling CompilerVisibleItemMetadata
* Additional tests for nested function contexts. * Override VisitFunctionPointerLoad in MethodToClassRewriter. * Adjust debug asserts.
…626.2 (#45482) Microsoft.DotNet.Arcade.Sdk From Version 1.0.0-beta.20302.3 -> To Version 1.0.0-beta.20326.2 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
We have two members in TypeKind that point to the same value, Struct and Structure. Because of this, Enum.ToString(), which under the covers uses a binary search, isn't stable which one it will pick and it can change if other TypeKinds are added. This ensures we keep using the same string consistently. We also have a few members in MethodKind that are also duplicates, but it appears those have kept stable. To be safe, we now serialize explicitly. Fixes #44714
Function pointer bug fixes
Reduce memory required for document change processing queues
Update Language Feature Status
…nsistency Fix up nondeterminism in serializing naming style preferences
ghost
approved these changes
Jun 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auto-approval
ghost
deleted the
merges/master-to-features/source-generators
branch
June 28, 2020 01:33
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/source-generators.
git fetch --all git checkout merges/master-to-features/source-generators git reset --hard upstream/features/source-generators git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/source-generators --force
Once all conflicts are resolved and all the tests pass, you are free to merge the pull request.