Skip to content

Conversation

@dibarbet
Copy link
Member

Fixes - https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1145547/

Long term support for snippets is coming in late 16.8 timeframe. Until then since committing these items does nothing, we should remove them from the LSP completion results.

@dibarbet dibarbet added Bug Area-IDE LSP issues related to the roslyn language server protocol implementation labels Jun 29, 2020
@dibarbet dibarbet requested review from allisonchou and genlu June 29, 2020 21:10
@dibarbet dibarbet requested a review from a team as a code owner June 29, 2020 21:10
Copy link
Contributor

@allisonchou allisonchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dibarbet dibarbet changed the base branch from master to release/dev16.7 June 29, 2020 23:58
@jinujoseph jinujoseph added this to the 16.7.P4 milestone Jun 30, 2020
@dibarbet dibarbet merged commit 69d0238 into dotnet:release/dev16.7 Jun 30, 2020
@dibarbet dibarbet deleted the disable_snippets branch June 30, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved to merge Area-IDE Bug LSP issues related to the roslyn language server protocol implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants