Add VisualStudio2019.pkgdef to the Roslyn package #45858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are reports of Roslyn colors not being applied on first run following a VS upgrade. This is the first step to resolving this for customers. By including our colors as a pkgdef we can ensure that there are colors available for our classifications when the configuration is rebuilt. Then to address why colors might not be applying to the registry, Telemetry will be added (#45304). We will also add a delayed ClassificationMap check to ensure colors were applied properly (#45852).
Since requiring this pkgdef to be kept in sync with the color xml is not sustainable, I've opened an issue to generate the pkgdef during the build (#45857).