Skip to content

Conversation

@cristianosuzuki77
Copy link

No description provided.

@cristianosuzuki77 cristianosuzuki77 requested review from a team as code owners July 10, 2020 01:40
@vatsalyaagrawal vatsalyaagrawal added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Jul 10, 2020
@wli3
Copy link

wli3 commented Jul 10, 2020

@JoeRobich there will be a Roslyn insertion later right?

@JoeRobich
Copy link
Member

@JoeRobich there will be a Roslyn insertion later right?

@wli3 We plan to take this and a few other changes for Preview 5 next week.

Copy link
Member

@huoyaoyuan huoyaoyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some obviously wrong translation. Not touching the "correct but unnatural" ones.
I want you to forward the feedback to translation team, thanks!

<trans-unit id="Remove_unnecessary_suppression_operator">
<source>Remove unnecessary suppression operator</source>
<target state="new">Remove unnecessary suppression operator</target>
<target state="translated">请删除不必要的禁止使用的运算符</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="translated">请删除不必要的禁止使用的运算符</target>
<target state="translated">请删除不必要的忽略运算符</target>

<trans-unit id="Remove_suppression_operators">
<source>Remove suppression operators</source>
<target state="new">Remove suppression operators</target>
<target state="translated">请删除禁止使用的运算符</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="translated">请删除禁止使用的运算符</target>
<target state="translated">请删除忽略运算符</target>

<trans-unit id="ERR_BadInheritanceFromRecord">
<source>Only records may inherit from records.</source>
<target state="new">Only records may inherit from records.</target>
<target state="translated">只有记录可以从记录中继承。</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="translated">只有记录可以从记录中继承。</target>
<target state="translated">只有记录可以从记录继承。</target>

<trans-unit id="ERR_CopyConstructorMustInvokeBaseCopyConstructor">
<source>A copy constructor in a record must call a copy constructor of the base, or a parameterless object constructor if the record inherits from object.</source>
<target state="new">A copy constructor in a record must call a copy constructor of the base, or a parameterless object constructor if the record inherits from object.</target>
<target state="translated">如果记录继承自对象,则记录中的复制构造函数必须调用基对象的复制构造函数,或者调用无参数的对象构造函数。</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="translated">如果记录继承自对象,则记录中的复制构造函数必须调用基对象的复制构造函数,或者调用无参数的对象构造函数。</target>
<target state="translated">如果记录继承自 object ,则记录中的复制构造函数必须调用基对象的复制构造函数,或者调用无参数的对象构造函数。</target>

<trans-unit id="ERR_DoesNotOverrideMethodFromObject">
<source>'{0}' does not override the method from 'object'.</source>
<target state="new">'{0}' does not override the method from 'object'.</target>
<target state="translated">“{0}”不会通过 "object" 覆盖方法。</target>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<target state="translated">“{0}”不会通过 "object" 覆盖方法。</target>
<target state="translated">“{0}”不会覆盖 "object" 的方法。</target>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are working on review of these suggestions

@wli3
Copy link

wli3 commented Jul 13, 2020

@huoyaoyuan thank you for your suggestions. However due to the process, your advice will not reflect to the code in a short time.

@janbaltus could you incorporate the suggestion into your database?

@JoeRobich please go ahead and merge this change. A later loc pass will have the suggestions.

@wli3
Copy link

wli3 commented Jul 14, 2020

@JoeRobich ping to merge

@JoeRobich
Copy link
Member

@wli3 Still waiting on QB approval for a Preview 5 insertion.

@JoeRobich JoeRobich merged commit a303c0d into dotnet:release/dev16.7-vs-deps Jul 16, 2020
@cristianosuzuki77 cristianosuzuki77 deleted the release/dev16.7-vs-deps branch July 20, 2020 16:25
@cristianosuzuki77
Copy link
Author

Suggestions were incorporated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved to merge Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants