Gracefully handle exceptions in code fixer creation #45865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#45851 This happened because an abstract fixer type had ExportCodeFixProvider attribute, which caused VS Crash on Ctrl + Dot operation. See dotnet/roslyn-analyzers#3843
jmarolf
reviewed
Jul 16, 2020
| private readonly IDiagnosticAnalyzerService _diagnosticService; | ||
|
|
||
| private readonly ImmutableDictionary<LanguageKind, Lazy<ImmutableDictionary<DiagnosticId, ImmutableArray<CodeFixProvider>>>> _workspaceFixersMap; | ||
| private readonly Func<Workspace, ImmutableDictionary<LanguageKind, Lazy<ImmutableDictionary<DiagnosticId, ImmutableArray<CodeFixProvider>>>>> _getWorkspaceFixersMap; |
jmarolf
reviewed
Jul 16, 2020
Contributor
Author
|
@jmarolf @CyrusNajmabadi any further feedback? Thanks. |
jmarolf
reviewed
Jul 16, 2020
jmarolf
approved these changes
Jul 16, 2020
CyrusNajmabadi
approved these changes
Jul 16, 2020
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45851
This happened because an abstract fixer type had ExportCodeFixProvider attribute, which caused VS Crash on Ctrl + Dot operation. See dotnet/roslyn-analyzers#3843