Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip flaky test #45878

Merged
1 commit merged into from
Jul 10, 2020
Merged

Skip flaky test #45878

1 commit merged into from
Jul 10, 2020

Conversation

333fred
Copy link
Member

@333fred 333fred commented Jul 10, 2020

Related to #45877

@333fred 333fred requested a review from a team as a code owner July 10, 2020 18:25
@333fred 333fred added Area-IDE Disabled Test Test Test failures in roslyn-CI labels Jul 10, 2020
kevinsun-dev
kevinsun-dev approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@kevinsun-dev kevinsun-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, been failing fairly inconsistently for me. Sounds like a good change. (iteration 1)

ghost
ghost approved these changes Jul 10, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 65ef3e3 into dotnet:master Jul 10, 2020
@333fred 333fred deleted the disable-TestDefaultDiagnosticProviderSemantic branch July 10, 2020 22:08
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinsun-dev kevinsun-dev kevinsun-dev approved these changes

@mavasani mavasani mavasani approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

Assignees
No one assigned
Labels
Area-IDE auto-merge Disabled Test Test Test failures in roslyn-CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@333fred @jasonmalinowski @mavasani @kevinsun-dev