Include information why symbol key resolution has failed to help with debugging. #45942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jul 13, 2020
Member
Author
There was a problem hiding this comment.
general pattern when a subportion fails is: (this type failed resolving this piece of data -> due to this underlying cause). The parens are there for nesting to make all the nested reasons something that can be grokked.
CyrusNajmabadi
force-pushed
the
symKeyFailureReason
branch
from
a9ee370 to
a34deb3
Compare
Member
Author
|
Tagging @dotnet/roslyn-ide @jasonmalinowski |
CyrusNajmabadi
force-pushed
the
symKeyFailureReason
branch
from
c6ed199 to
02f6ac8
Compare
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting a few crashes with OOP where symbol keys fail to resolve to/from the oop/host side. Previously, one thing that caused this was an inability tou roundtrip some error symbols. However, that issue was fixed and we're still seeing some sporatic failures.
This PR updates symbolkeys to report back a detailed reasoning on why they failed so that we can get that information in teh dump and potentially determine any commonality between the failures (i.e. maybe it's something to do with certain types of symbols).
This does not get rid of any issues, but only seeks to include more information to make future investigations more fruitful.