Nullable annotate InvisibleEditor.cs #45978
Conversation
There was a problem hiding this comment.
VsTextLines has been revised to never be null.
There was a problem hiding this comment.
It's not clear to me why this was only using an 'as' cast to convert the docData to an IVsTextLines. We had a hard cast to IVsTextBuffer a line later, and although it's possible that somebody could implement IVsTextBuffer but not IVsTextLines, I can't think of any reasonable scenario for that. Worse off, the only objects here that can be passed to GetDocumentBuffer and actually work would be the editor implementations anyways which would implement all the interfaces.
I'm figuring this all just evolved this way for no good reason, so I'm cleaning it up.
There was a problem hiding this comment.
@davkean The AbtractHostObject stuff would all have been the fake IVsHierarchies you used to create for each target; that's all gone now right? I imagine we can delete this hack entirely.
jasonmalinowski
force-pushed
the
nullable-annotate-invisibleeditor
branch
from
19f280e to
34fb647
Compare
sharwell
added
Area-IDE
Concept-Null Annotations
There was a problem hiding this comment.
❔ Where would the previous implementation have thrown if this invariant was violated?
There was a problem hiding this comment.
Calling the VS API with an empty file path wouldn't have worked, that much is certain.
There was a problem hiding this comment.
❔ How do we know FilePath is not null here? Is there already validation of this condition earlier in the code path?
There was a problem hiding this comment.
Ditto: code never could have worked prior. And more practically, remote files are backed by the file system in a certain magic temp directory.
jasonmalinowski
force-pushed
the
nullable-annotate-invisibleeditor
branch
from
34fb647 to
fb34e59
Compare
ghost
added this to the
3 participants
No description provided.