Skip to content

Conversation

@dibarbet
Copy link
Member

@dibarbet dibarbet commented Jul 15, 2020

This removes one of them. liveshare has a corresponding PR to remove the other.

https://devdiv.visualstudio.com/DefaultCollection/DevDiv/_git/Cascade/pullrequest/261297?_a=files

Verified that after this PR there is only one (other pending liveshare insertion).

@dibarbet dibarbet requested a review from tmat July 15, 2020 22:20
@dibarbet dibarbet requested a review from a team as a code owner July 15, 2020 22:20
@dibarbet dibarbet added the LSP issues related to the roslyn language server protocol implementation label Jul 15, 2020
Copy link
Member

@davidwengier davidwengier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://media.giphy.com/media/T4wjVXITmByQ8/giphy.gif

Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye Felicia

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 61e5f0b into dotnet:master Jul 16, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE auto-merge LSP issues related to the roslyn language server protocol implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants