Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #46136

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Update README #46136

merged 2 commits into from
Jul 27, 2020

Conversation

tmat
Copy link
Member

@tmat tmat commented Jul 20, 2020

Add links to NuGet feeds, reorder sections - move CI status to the bottom.

@tmat
Update README
c4392bb 
Add links to NuGet feeds, reorder sections.
@tmat
Copy link
Member Author

tmat commented Jul 20, 2020 •
edited
Loading

@jaredpar @jinujoseph @mikadumont @kendrahavens @JoeRobich @jasonmalinowski @dotnet/roslyn PTAL

JoeRobich
JoeRobich reviewed Jul 20, 2020
View reviewed changes
README.md Outdated
@@ -53,6 +23,10 @@ To install the latest release without Visual Studio, download the [.NET SDK nigh

See [what's new with the C# and VB compilers](https://github.com/dotnet/roslyn/wiki/Changelog-for-C%23-and-VB-compilers).

**Pre-release builds** are available from the following public NuGet feeds:
- [Compiler](https://dev.azure.com/dnceng/public/_packaging?_a=feed&feed=dotnet5): `https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet5/nuget/v3/index.json`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that to get rolling Compiler builds they would need to reference the dotnet-tools feed instead? dotnet5 seems to track the latest sdk preview.

Copy link
Member Author

@tmat tmat Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the Compiler link to point to dotnet-tools and added .NET SDK as a separate feed. Looks good?

jasonmalinowski
jasonmalinowski approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never liked that we had CI first, since it was probably the least useful for somebody actually wanting to read our README. 😄

333fred
333fred reviewed Jul 24, 2020
View reviewed changes
README.md Outdated


[//]: # (End current test results)
Roslyn provides open-source C# and Visual Basic compilers with rich code analysis APIs. It enables building code analysis tools with the same APIs that are used by Visual Studio.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like badges should go at the top. Most repos I've seen have the discussion links at the top and I don't see any need to break with that form.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does anyone care about status of 30 build pipelines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any form being broken. https://github.com/dotnet/runtime

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just mean the chat links. And in that example, the gitter link is above the summary.

Copy link
Member Author

@tmat tmat Jul 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved chat links higher up.

JoeRobich
JoeRobich approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tmat tmat merged commit 793ffaa into master Jul 27, 2020
@ghost ghost added this to the Next milestone Jul 27, 2020
@tmat tmat deleted the dev/tmat/readme branch July 27, 2020 22:18
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 28, 2020
@333fred
Merge remote-tracking branch 'upstream/master' into features/function…
cb3cc96 
…-pointers

* upstream/master: (207 commits)
  Update argument state when parameter has not-null type (dotnet#46072)
  Fix TypeWithAnnotations.ToTypeWithState() for (untyped) null literal (dotnet#46344)
  Update README (dotnet#46136)
  Revert "Revert "Support nullable annotations on unconstrained type parameters""
  Revert "Support nullable annotations on unconstrained type parameters (dotnet#45993)"
  Fix type in publish data
  Update VSIXExpInstaller version to one available on ADO
  Update publish data for 16.8
  Update version of RichCodeNav.EnvVarDump
  A fixed initializer must be bound to its natural type (dotnet#46293)
  Update features merged into 16.7p4 (dotnet#46229)
  Async-streams: disposal should continue without jump within a finally (dotnet#46188)
  Recommend default in type constraint, but not record (dotnet#46311)
  Add use site diagnostics to IsUnmanaged (dotnet#46114)
  Add another flaky test.
  Ensure NuGet connections use TLS 1.2
  Update to Microsoft.CodeAnalysis.Testing 1.0.1-beta1.20374.2
  Skip flaky test.
  Fix build break. (dotnet#46303)
  Skip a flaky test Relates to dotnet#46304
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Jul 28, 2020
@333fred
Merge remote-tracking branch 'upstream/features/function-pointers' in…
cdb7a8f 
…to function-pointer-type-lookup

* upstream/features/function-pointers: (212 commits)
  Correct public API number.
  Update argument state when parameter has not-null type (dotnet#46072)
  Fix TypeWithAnnotations.ToTypeWithState() for (untyped) null literal (dotnet#46344)
  Update README (dotnet#46136)
  Revert "Revert "Support nullable annotations on unconstrained type parameters""
  Revert "Support nullable annotations on unconstrained type parameters (dotnet#45993)"
  Fix type in publish data
  Update VSIXExpInstaller version to one available on ADO
  Update publish data for 16.8
  Update version of RichCodeNav.EnvVarDump
  A fixed initializer must be bound to its natural type (dotnet#46293)
  Update features merged into 16.7p4 (dotnet#46229)
  Async-streams: disposal should continue without jump within a finally (dotnet#46188)
  Recommend default in type constraint, but not record (dotnet#46311)
  Add use site diagnostics to IsUnmanaged (dotnet#46114)
  Add another flaky test.
  Ensure NuGet connections use TLS 1.2
  Update to Microsoft.CodeAnalysis.Testing 1.0.1-beta1.20374.2
  Skip flaky test.
  Fix build break. (dotnet#46303)
  ...
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred left review comments

@jaredpar jaredpar jaredpar approved these changes

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@JoeRobich JoeRobich JoeRobich approved these changes

@jmarolf jmarolf jmarolf approved these changes

@jinujoseph jinujoseph jinujoseph approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
16.8.P2
Development

Successfully merging this pull request may close these issues.
8 participants
@tmat @jaredpar @jasonmalinowski @JoeRobich @333fred @jmarolf @jinujoseph @RikkiGibson