Skip to content

Fix InteractiveHost32 build #46211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jul 22, 2020
Merged

Fix InteractiveHost32 build #46211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Interactive/HostTest/InteractiveHost.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,13 @@
<!--
Not using ProjectReference since it does not execute the specified targets when building in VS.
See https://github.com/microsoft/msbuild/issues/5434.
Note: do not set TargetFramework=net472 for InteractiveHost32. The project is not multi-targeted.
Setting the property would create a build configuration that's different from the one the solution uses
and thus would result in building the project twice.
-->

<CopyPublishedOutputProjectReference Include="..\HostProcess\InteractiveHost32.csproj">
<SetTargetFramework>TargetFramework=net472</SetTargetFramework>
<OutputItemType>InteractiveHostFiles_Desktop32</OutputItemType>
</CopyPublishedOutputProjectReference>

Expand Down
7 changes: 5 additions & 2 deletions src/VisualStudio/Setup/Roslyn.VisualStudio.Setup.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,11 @@
<ProjectReference Include="..\..\Interactive\HostProcess\InteractiveHost32.csproj">
<Name>InteractiveHost.Desktop32</Name>

<SetTargetFramework>TargetFramework=net472</SetTargetFramework>
<SkipGetTargetFrameworkProperties>true</SkipGetTargetFrameworkProperties>
<!--
Note: do not set TargetFramework=net472 for InteractiveHost32. The project is not multi-targeted.
Setting the property would create a build configuration that's different from the one the solution uses
and thus would result in building the project twice.
-->
<ReferenceOutputAssembly>false</ReferenceOutputAssembly>

<Private>false</Private>
Expand Down