Skip to content

Conversation

@gafter
Copy link
Member

@gafter gafter commented Jul 24, 2020

Relates to #46304

@gafter gafter added this to the 16.8 milestone Jul 24, 2020
@gafter gafter requested review from chsienki, jaredpar and tmat July 24, 2020 15:45
@gafter gafter requested a review from a team as a code owner July 24, 2020 15:45
@gafter gafter self-assigned this Jul 24, 2020
@tmat
Copy link
Member

tmat commented Jul 24, 2020

The extra path to fallback directory should be included in the output. Not sure why would it pass otherwise - it's possible that some versions of the SDK didn't have both paths.

BTW, the path is set to an incorrect value (tracked by NuGet/Home#9810), but that value should be stable.

@gafter
Copy link
Member Author

gafter commented Jul 24, 2020

@tmat That comment might be more useful in #46304. This PR is just to skip the test until it is addressed.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit 7e9bff7 into dotnet:master Jul 24, 2020
@ghost ghost modified the milestones: 16.8, Next Jul 24, 2020
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants