Fix roundtripping of generic error types. #46357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@jinujoseph Would likely want to take this for 16.7 |
Member
|
@CyrusNajmabadi Do you want to just target 16.7 with this now? |
Contributor
|
@CyrusNajmabadi lets retarget to 16.8.P1 branch ..I will get the approval |
ryzngard
approved these changes
Jul 27, 2020
CyrusNajmabadi
force-pushed
the
genericErrorType
branch
from
01d5948 to
2e5cc7f
Compare
Member
Author
|
This is against 16.8p1 now. @jasonmalinowski Does that automatically merge back into master? |
Member
|
@CyrusNajmabadi Yep, we auto-merge for you. |
jasonmalinowski
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39936
Fixes OOP crash when rountripping user code in error.